Switch to pyproject.toml
#830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
@fsschneider Thanks for the tag and the acknowledgement of the 2 cents of work I've previously added to this engineering topic. From a quick look, here are some notes
I will try to make more free space for this, have had a lot of focus on some PhD work in the past 2 months, but hey, time in one's agenda is not to be founded but has to be created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the current
setup.cfgandsetup.pywith (hopefully) equivalentpyproject.toml.As described in #803 this is the PEP standard for package setup.
It probably doesn't fully resolve said issue as it also included more proposed changes du the dataset setup.
Note: We plan to move to
ruff(replacingisort,pylintandyapf) as well as renaming the package toalgoperf. Therefore, thepyproject.tomlwill change substantially with follow-up PRs.@IFFranciscoME, I currently can't add you as a reviewer, but I am happy to hear your feedback as well.